Skip to content

feat: upgrade package manager to pnpm #15546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 3, 2025
Merged

feat: upgrade package manager to pnpm #15546

merged 11 commits into from
Jun 3, 2025

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented May 30, 2025

Description

  • Primary update: Implements pnpm as canonical package manager. Dependency requirements are a bit different with pnpm compared to yarn, and all package versions have been updated accordingly to comply.
  • Enables corepack for package manager version control; version maintained in package.json (Enable with corepack enable)
  • Updates README and other docs, removing all instructions that utilized yarn and updated to pnpm instructions
  • Updated any workflow package manager usage

Copy link

netlify bot commented May 30, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit f7e12a3
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/683df3f03fde3f0008313242
😎 Deploy Preview https://deploy-preview-15546--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 46 (🟢 up 2 from production)
Accessibility: 95 (🟢 up 1 from production)
Best Practices: 91 (no change from production)
SEO: 99 (🟢 up 1 from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added config ⚙️ Changes to configuration files dependencies 📦 Changes related to project dependencies documentation 📖 Change or add documentation tooling 🔧 Changes related to tooling of the project labels May 30, 2025
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @wackerow! thanks for the migration and lodash normalization :)

Left a comment about something related to crowdin that seems unrelated to the pnpm migration. Could you elaborate more on those changes?

@@ -62,16 +60,6 @@ export const CROWDIN_PROJECT_URL = "https://crowdin.com/project/ethereum-org"
export const CROWDIN_PROJECT_ID = 363359
export const CROWDIN_API_MAX_LIMIT = 500
export const FIRST_CROWDIN_CONTRIBUTION_DATE = "2019-07-01T00:00:00+00:00"
export const REGULAR_RATES: ReportsModel.RegularRate[] = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used? 👍🏼

@@ -25,22 +24,45 @@ export async function fetchTranslationCostsReport(

// Todo: Remove ts-ignore when this PR gets merged
// https://github.com/crowdin/crowdin-api-client-js/pull/282
const schema: ReportsModel.TranslationCostSchema = {
// const schema: ReportsModel.TranslationCostSchema = {
const schema: ReportsModel.TranslationCostsPostEndingSchema = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't seem the PR to include this change. do we need to test something? not sure what this change is doing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some changes to the data schema required from the crowdin package. We can check with @lukassim but I'm not sure we really even use this anymore, but in the meantime I tried my best o update to match the new schema.

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pettinarip pettinarip merged commit 07bb4fe into dev Jun 3, 2025
8 of 10 checks passed
@pettinarip pettinarip deleted the pnpm branch June 3, 2025 07:54
This was referenced Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙️ Changes to configuration files dependencies 📦 Changes related to project dependencies documentation 📖 Change or add documentation tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants