fix: prevent cookie transfers during external data loads #15504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
changed the title
wackerow
requested review from
corwintines,
pettinarip and
minimalsm
as code owners
pettinarip
approved these changes
May 28, 2025
| const response = await fetch(url) | ||
| const response = await fetch(url, { | ||
| headers: { Cookie: "", DNT: "1" }, // Empty cookie header and do-not-track | ||
| credentials: "omit", // Don't send or receive cookies |
There was a problem hiding this comment.
interesting, wonder if we should apply more of this in the other fetches for external data
This was referenced May 28, 2025
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
credentials: "omit", ensuring cookies are not sent with these requests.referrerPolicy="no-referrer"andcrossOrigin="anonymous"attributes on certain<img>tags to enhance privacy and security when loading images from external sources.Related Issue
Fixes third-party cookies inadvertantly being loaded from external fetches