Skip to content

Fix layout component logic #15451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 23, 2025
Merged

Fix layout component logic #15451

merged 7 commits into from
May 23, 2025

Conversation

wackerow
Copy link
Member

Description

  • fix: layout component set logic... Bug existed causing last set of custom components spread into an object to override everything else, causing the markdown components for the "tutorial" layout to be dominant.
  • feat: update h2 styling; removes mono and uppercase font properties
  • refactor: use tw classes for default bg and color in Codeblock component (semi-patches a small color-mode bug I'm seeing with the update to the components)

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label May 15, 2025
Copy link

netlify bot commented May 15, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit f7c8dd4
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/683108a5d5a502000844858a
😎 Deploy Preview https://deploy-preview-15451--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 44 (🔴 down 11 from production)
Accessibility: 95 (🟢 up 1 from production)
Best Practices: 91 (🔴 down 8 from production)
SEO: 99 (🔴 down 1 from production)
PWA: 59 (🟢 up 1 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nloureiro
Copy link
Contributor

@wackerow looks great ship it!!!

Screen Shot 2025-05-16 10 03 26 AM

@wackerow wackerow changed the title Fix h fonts Fix layout component logic May 16, 2025
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicee! LGTM

@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label May 16, 2025
@wackerow
Copy link
Member Author

Build failed before from "CardGrid" not being pass through for the "use-cases" template, which was previously masked because we spread them all together. Refactored a touch to grab the re-used custom styling <CardGrid className="grid grid-cols-[repeat(auto-fill,_minmax(min(100%,_280px),_1fr))] gap-8"> and just pass that from the UseCases template, converting in-markdown usage to <CardGrid>.. Built properly locally, Netlify going now... can pull in if successful.

@wackerow wackerow merged commit ddedb41 into dev May 23, 2025
6 of 7 checks passed
@wackerow wackerow deleted the fix-h-fonts branch May 23, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants