Skip to content

Intl redirect bug #15428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 12, 2025
Merged

Intl redirect bug #15428

merged 9 commits into from
May 12, 2025

Conversation

corwintines
Copy link
Member

@corwintines corwintines commented May 11, 2025

Description

https://nextjs.org/docs/app/api-reference/file-conventions/middleware
https://next-intl.dev/docs/routing/middleware

Resolves issues around redirect with default locale, and crawler issues coming from the redirect issue

Related issue

Copy link

netlify bot commented May 11, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 94b98a8
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/682209cde6fb0f0008b6f557
😎 Deploy Preview https://deploy-preview-15428--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 43 (🔴 down 5 from production)
Accessibility: 95 (🟢 up 1 from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@corwintines corwintines changed the title [WIP] Intl bug Intl redirect bug May 12, 2025
wackerow
wackerow previously approved these changes May 12, 2025
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @corwintines! 🔥

@corwintines corwintines changed the base branch from dev to master May 12, 2025 16:52
@corwintines corwintines dismissed wackerow’s stale review May 12, 2025 16:52

The base branch was changed.

@corwintines corwintines merged commit 4a31111 into master May 12, 2025
6 checks passed
@corwintines corwintines deleted the intl-bug branch May 12, 2025 16:52
This was referenced May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ethereum.org links without language returns error 404
5 participants