Hotfix reading time for tutorials #15202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettinarip
requested review from
wackerow,
corwintines and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
corwintines
approved these changes
Mar 28, 2025
This was referenced Apr 16, 2025
Merged
vm06007
reviewed
Apr 17, 2025
| @@ -97,8 +98,7 @@ export default async function Page({ | |||
| lastEditLocaleTimestamp={lastEditLocaleTimestamp} | |||
| contentNotTranslated={!isTranslated} | |||
| contributors={contributors} | |||
| // TODO: Remove this once we have a real timeToRead value | |||
| timeToRead={2} | |||
| timeToRead={Math.round(timeToRead.minutes)} | |||
There was a problem hiding this comment.
might need to add a default value here as a fallback in case timeToRead.minutes returns something undefined
Afeter8
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes hardcoded read time for tutorials and calculate it using
reading-timelib.