Skip to content

Hide listen to player on non-english pages #15170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

Hide listen to player on non-english pages #15170

merged 2 commits into from
Mar 25, 2025

Conversation

corwintines
Copy link
Member

Description

  • Hides the listen to player on non english pages since this content is only in english at the moment

@netlify Netlify
Copy link

netlify bot commented Mar 25, 2025 •
edited
Loading

❌ Deploy Preview for ethereumorg failed.

Name Link
🔨 Latest commit 06a19f6
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67e317446a1bfa0008d97342

wackerow
wackerow approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works for now... if new languages get added can find a way to query for which are available.

wackerow
wackerow approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean 😎

@wackerow wackerow merged commit 6da50b5 into dev Mar 25, 2025
3 of 7 checks passed
@wackerow wackerow deleted the hideListenToNonEnglish branch March 25, 2025 20:52
@corwintines
Copy link
Member Author

Nice, works for now... if new languages get added can find a way to query for which are available.

Yeah, thats a future Corwin problem XD

This was referenced Mar 26, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackerow wackerow wackerow approved these changes

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corwintines @wackerow