Skip to content

Tech debt #15160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 25, 2025
Merged

Tech debt #15160

merged 7 commits into from
Mar 25, 2025

Conversation

wackerow
Copy link
Member

Description

Cleans up some tech debt by clearing many of the build warnings that have been accumulating.

Warning: Using could result in slower LCP and higher bandwidth. Consider usingfromnext/image to automatically optimize images. This may incur additional usage or cost from your provider. See: https://nextjs.org/docs/messages/no-img-element @next/next/no-img-element

  • src/components/Contributors.tsx - allow listed src domain in next config
  • src/components/EventCard.tsx - ignored warning since check if being performed
  • src/components/StablecoinsTable.tsx - allow listed src domain in next config

Warning React Hook useEffect has missing dependencies

  • src/components/DataTable/index.tsx
  • src/components/ListenToPlayer/PlayerWidget/index.tsx
  • src/components/ListenToPlayer/index.tsx
  • src/components/ProductTable/index.tsx
  • src/components/Quiz/QuizWidget/useQuizWidget.tsx
  • src/components/Translatathon/CountdownBanner.tsx

Warning Using mock data

  • Moved to higher scope to reduce number of times this fires (does not change during single build)

Warning Link component is missing href prop

  • Updated warning, adding pathname to help trace
  • Culprits was h1's in the body of markdown files which breaks our AST rules
    • src/pages/developers/tutorials/erc-721-vyper-annotated-code.mdx
    • src/pages/developers/tutorials/waffle-test-simple-smart-contract.mdx
    • src/pages/developers/docs/design-and-ux/dex-design-best-practice.mdx

Related Issue

None filed directly; related to above build warnings

@github-actions github-actions bot added config ⚙️ Changes to configuration files content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project labels Mar 25, 2025
Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 5e9cd08
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67e203638f329d00080854ad
😎 Deploy Preview https://deploy-preview-15160--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 54 (🔴 down 6 from production)
Accessibility: 95 (🟢 up 1 from production)
Best Practices: 89 (🔴 down 8 from production)
SEO: 98 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@corwintines corwintines self-assigned this Mar 25, 2025
Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much nicer 🚀

@corwintines corwintines merged commit 4112fd9 into dev Mar 25, 2025
8 of 10 checks passed
@corwintines corwintines deleted the tech-debt branch March 25, 2025 22:10
This was referenced Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙️ Changes to configuration files content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants