App router pages #15114
Merged
App router pages #15114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
force-pushed
the
app-router-pages
branch
from
847577a to
895ddde
Compare
pettinarip
requested review from
wackerow,
corwintines and
minimalsm
as code owners
wackerow
reviewed
Mar 26, 2025
wackerow
reviewed
Mar 26, 2025
There was a problem hiding this comment.
@pettinarip This looks great overall... Working well for me locally. Pushed one tiny patch, but there are still merge-conflicts, in particular with the /start/ page which appears to still need migrating/refactoring since it's using PageMetadata ands @/i18n/loadNamespace.
After those are cleared, I think this is ready to pull into dev
This was referenced Apr 16, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates all remaining pages in
/src/pages/[locale]to/app/[locale]and removes the pages directory.