Skip to content

fix(icons): update icons with createIconBase #14939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TylerAPfledderer
Copy link
Contributor

Description

Updates FilterBurgerIcon, EthHomeIcon, and FeedbackThumbsUpIcon to use createIconBase. This fixes improper rendering in the icon story, and syncs with the other icons on the list.

Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 2303d64
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67cf2ec89e5da90008052d3e
😎 Deploy Preview https://deploy-preview-14939--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 48 (🔴 down 10 from production)
Accessibility: 92 (no change from production)
Best Practices: 87 (🔴 down 8 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@TylerAPfledderer
Copy link
Contributor Author

@pettinarip should be good now.

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pettinarip pettinarip merged commit a53023c into ethereum:dev Mar 11, 2025
8 of 9 checks passed
@TylerAPfledderer TylerAPfledderer deleted the fix/icons-use-createIconBase branch March 11, 2025 12:03
This was referenced Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants