Skip to content

refactor(link-box): use asChild strategy for LinkBox component #14937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TylerAPfledderer
Copy link
Contributor

Description

Updates the LinkBox component to us the asChild strategy employed by the other UI components

Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit fa3576f
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67cdc6e27822b90008185663
😎 Deploy Preview https://deploy-preview-14937--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 45 (🔴 down 13 from production)
Accessibility: 92 (no change from production)
Best Practices: 87 (🔴 down 8 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@TylerAPfledderer TylerAPfledderer changed the title refactor(link-box): use asChild strategy for LinkBox` component refactor(link-box): use asChild strategy for LinkBox component Feb 19, 2025
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch

@pettinarip pettinarip merged commit 90cbc7b into ethereum:dev Mar 10, 2025
8 of 9 checks passed
@TylerAPfledderer TylerAPfledderer deleted the refactor/linkbox-asChild-strat branch March 10, 2025 17:43
This was referenced Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants