Skip to content

refactor(components): remove remaining Chakra imports #14905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TylerAPfledderer
Copy link
Contributor

@TylerAPfledderer TylerAPfledderer commented Feb 14, 2025

Description

Removes any leftover Chakra imports before taking out the theming config and provider. (Keeping these PR short to cover any unexpected issues)

This does not address the useColorMode hook in useNav, as that will be removed when removing the Chakra Theme Provider.

Also does not remove anything from the Chakra theme config or storybook, as this will also be addressed when removing the theme provider.

Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 6e56963
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67b37e607a8ece00090d251b
😎 Deploy Preview https://deploy-preview-14905--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 47 (🔴 down 4 from production)
Accessibility: 95 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@TylerAPfledderer TylerAPfledderer marked this pull request as ready for review February 17, 2025 18:23
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pettinarip pettinarip merged commit 9a82216 into ethereum:dev Feb 18, 2025
11 checks passed
@TylerAPfledderer TylerAPfledderer deleted the refactor/remove-remaining-chakra-components branch February 18, 2025 13:11
This was referenced Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants