Fix ProductCard #14714
Merged
Fix ProductCard #14714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeChenJ
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Closed
|
This issue is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
Status: Stale
wackerow
approved these changes
May 29, 2025
There was a problem hiding this comment.
Thanks for surfacing @JoeChenJ and sorry for delays!
Moved your change directly to the button to keep it tidy, and also ended up removing the fixed height on this button and adding a touch of y-padding so a 2-line button still looks nice
Pulling in!
This was referenced Jun 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The text in PorductCard button on developers/local-environment page doesn't look well
Screenshots
Before:
After:
Related Issue
N/A