Skip to content

Create story tests for BannerGrid components [#13046] #13567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 10, 2025
Merged

Create story tests for BannerGrid components [#13046] #13567

merged 15 commits into from
Jun 10, 2025

Conversation

Baystef
Copy link
Contributor

@Baystef Baystef commented Aug 2, 2024 •
edited
Loading

Create story tests for BannerGrid components

Description

  • Banner
  • BannerBody
  • BannerImage
  • BannerGrid
  • BannerGridCell

Related Issue

Closes #13046

@netlify Netlify
Copy link

netlify bot commented Aug 2, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 91c209d
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67073846d924ac0008a7e79d
😎 Deploy Preview https://deploy-preview-13567--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 48 (🔴 down 5 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Baystef Baystef marked this pull request as ready for review August 5, 2024 08:38
@corwintines corwintines self-assigned this Aug 28, 2024
@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Sep 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Nov 23, 2024
@corwintines corwintines merged commit 8db5636 into ethereum:dev Jun 10, 2025
8 of 10 checks passed
This was referenced Jun 12, 2025
Merged
Closed
@corwintines corwintines mentioned this pull request Jun 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corwintines corwintines corwintines approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees

@corwintines corwintines

Labels
Status: Stale This issue is stale because it has been open 30 days with no activity. tooling 🔧 Changes related to tooling of the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create issue for BannerGrid components
2 participants
@Baystef @corwintines