Skip to content

13199(docs):proofs & edit #13200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

m4sterbunny
Copy link
Contributor

@m4sterbunny m4sterbunny commented Jun 19, 2024

fixes for #13199
consistency of abrevs, reduces verboseness, clarifies 3 clients

Description
Proofing rounds fixes p2p mixed with P2P
Applies more common variant Proof of Stake
Reduces verboseness
Clarifies 3rd client required for block building in intro

DOES NOT fix line 25: It seems unlikely to me that "Consensus clients include the execution payload in every block", do they need validator client to assist them to do this? I don't have the domain knowledge to add value here, but the position of this information is under "What does the execution client do?", therefore at minimum, relocation probably advised.

replaces #13111 (my bad fork hygiene)

@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Jun 19, 2024
Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for ethereumorg failed. Why did it fail? →

Name Link
🔨 Latest commit 7ad3d80
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66729e5b1c88920008f36b8e

@wackerow
Copy link
Member

Hey @m4sterbunny!

The "Validator client" is part of the consensus client and not typically considered a third client. Personally not sure about most of these changes, and some of them ("Proof of Work") go directly against our established style guide.

Curious why we made the arrow in the image unidirectional? This should be a bidirectional arrow to show communication between them. Appears that this is the only change to that image so I would revert. (Engine JSON-RPC API, Engine API: A Visual Guide)

The P2P changes I'd support, but would open as an independent change; not sure about the rest. Going to close this out, but can discuss more in the issue #13199 if you want to elaborate on these changes.

@wackerow wackerow closed this Jun 19, 2024
@github-actions github-actions bot added the abandoned This has been abandoned or will not be implemented label Jun 19, 2024
@m4sterbunny
Copy link
Contributor Author

The validator client, while typically bundled with the Consensus client, does not need to be run >> this is an active decision that also requires stake >> IMO it helps to clarify this early as the term Full node could otherwise be misleading (Full implies you run everything from a low-knowledge persepective).

Unidirectional arrow is to clear up the implication that EL can "drive" CL. CL makes calls to EL via the Engine API not vv. Yes, the EL responds to these requests >> This was from Besu team when I was attempting to understand further, so I am trusting my source. Alt would be dotted arrow back from EL.

WRT issue templates -- I did shop, found nothing that matched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned This has been abandoned or will not be implemented content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants