Skip to content

Test consolidation with same source and target #4259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 10, 2025
Merged

Test consolidation with same source and target #4259

merged 7 commits into from
Apr 10, 2025

Conversation

mkalinin
Copy link
Contributor

@mkalinin mkalinin commented Apr 10, 2025 •
edited
Loading

Resolves #4257

@mkalinin mkalinin mentioned this pull request Apr 10, 2025
Closed
jtraglia
jtraglia approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again, can confirm this test fails if I comment out this conditional:

consensus-specs/specs/electra/beacon-chain.md

Lines 1639 to 1641 in 83639a6

# Verify that source != target, so a consolidation cannot be used as an exit
if consolidation_request.source_pubkey == consolidation_request.target_pubkey:
return

@jtraglia jtraglia merged commit 199331e into ethereum:dev Apr 10, 2025
4 checks passed
jtraglia pushed a commit that referenced this pull request Apr 10, 2025
@mkalinin @jtraglia
Test consolidation with same source and target (#4259)
3d26bbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraglia jtraglia jtraglia approved these changes

Assignees
No one assigned
Labels
Electra scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing test: consolidation with the same source and target
2 participants
@mkalinin @jtraglia