Skip to content

Clean up electra presets #4254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

Clean up electra presets #4254

merged 1 commit into from
Apr 9, 2025

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Apr 8, 2025

I was reviewing this and had several nits:

  • The sections (naming, order) should match the spec but didn't.
  • In preset files, we don't do the uint64 type casting.
  • The comment for MAX_PENDING_DEPOSITS_PER_EPOCH was wrong.
  • Several other small things...

mkalinin
mkalinin approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jtraglia jtraglia merged commit bf09ede into ethereum:dev Apr 9, 2025
13 checks passed
@jtraglia jtraglia deleted the cleanup-presets branch April 9, 2025 12:46
jtraglia added a commit that referenced this pull request Apr 10, 2025
@jtraglia
Clean up electra presets (#4254)
bc46a61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkalinin mkalinin mkalinin approved these changes

@GabrielAstieres GabrielAstieres GabrielAstieres approved these changes

Assignees
No one assigned
Labels
Electra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtraglia @mkalinin @GabrielAstieres