Use mdformat
for markdown formatting
#4244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reviewing old PRs and saw this:
After reviewing
mdformat
I realized this is exactly what we've been looking for! It fixes these issues:For this, I used the following extensions for GitHub flavored markdown and for table of contents:
The benefits of
mdformat
...doctoc
(1.2 seconds vs 10.7 seconds, ~9x faster).I had to make one notable non-formatting change to get this to work:
[0]: # (eth2spec: skip)
with<!-- eth2spec: skip -->
The formatter was removing these footnotes because they unused, makes sense. My solution was to update this to use an HTML comment instead. The change in the pyspec generator was easy and arguably better than before.