add findKeys method for CouchDB #79
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Afaik this should not be how it's done. |
|
:S I might look it further, but being in a hurry I can't do it right now. |
|
Adding findAllPads to the module is wrong. findAllPads is a method exclusive to Etherpad. That logic needs to be in Etherpad and not ueberDB :) Make sense? Look at the other modules for ueberDB, you will see they don't contain findAllPads |
|
You're right 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'v added the findKeys methods for being able to use the
listAllPadsmethods of Etherpad.Also the felix-couchdb was missing in the package.json.
And about felix-couchdb, it was also broken for me… so I made a pull request in order to make it work. Without this patch, this module will sadly throw errors 😞