Skip to content

Split other methods in txn into separate files #19826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

serathius
Copy link
Member

@fuweid
Copy link
Member

fuweid commented Apr 29, 2025

Will revisit this pr after #19811 merged. Overall, it looks good.

@serathius serathius force-pushed the refactor-txn-files branch from 8af9826 to ef21176 Compare April 29, 2025 16:09
@serathius
Copy link
Member Author

Done

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fuweid, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 91.70984% with 16 lines in your changes missing coverage. Please review.

Project coverage is 68.87%. Comparing base (1a3a5a4) to head (ef21176).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
server/etcdserver/txn/range.go 90.82% 10 Missing ⚠️
server/etcdserver/txn/put.go 92.98% 2 Missing and 2 partials ⚠️
server/etcdserver/txn/delete.go 92.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/txn/txn.go 94.67% <ø> (+0.81%) ⬆️
server/etcdserver/txn/delete.go 92.59% <92.59%> (ø)
server/etcdserver/txn/put.go 92.98% <92.98%> (ø)
server/etcdserver/txn/range.go 90.82% <90.82%> (ø)

... and 35 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19826      +/-   ##
==========================================
+ Coverage   68.54%   68.87%   +0.32%     
==========================================
  Files         416      424       +8     
  Lines       35677    35876     +199     
==========================================
+ Hits        24456    24710     +254     
+ Misses       9786     9739      -47     
+ Partials     1435     1427       -8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a3a5a4...ef21176. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serathius serathius merged commit e4fb13d into etcd-io:main Apr 29, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants