osutil: remove unused Unsetenv function #16787
Conversation
The osutil.Unsetenv function is not used. Today, os.Unsetenv exists in the standard library, and is already used elsewhere in etcd. Removing this function could break things that may be importing this package. According to pkg.go.dev, it seems like the only thing is etcd forks, so it may be worth getting rid of this code. See: https://pkg.go.dev/github.com/coreos/etcd/pkg/osutil?tab=importedby Signed-off-by: Evan Jones <[email protected]>
|
Feel free to reject this change. I noticed this while looking for things that may be calling os.Setenv due to golang/go#63567 ; I figured removing this would probably make sense. This is just a clean up that shouldn't do anything. |
There was a problem hiding this comment.
It's a public function. It might be used by applications.
But why does etcd have to implement such public function? Especially it has already been supported by https://pkg.go.dev/os#Unsetenv.
I agree to remove it anyway.
|
Hey @ahrtr - Had a quick scan on GitHub and I can't see any meaningful references to Of course someone could be renaming the import package but I think the risk would be low and the OP has also checked pkg.go.dev which only showed etcd forks. With two reviewer approvals and one maintainer approval are we ok to merge this for |
OK, merging... thx |
The osutil.Unsetenv function is not used. Today, os.Unsetenv exists in the standard library, and is already used elsewhere in etcd. Removing this function could break things that may be importing this package. According to pkg.go.dev, it seems like the only thing is etcd forks, so it may be worth getting rid of this code. See:
https://pkg.go.dev/github.com/coreos/etcd/pkg/osutil?tab=importedby
Signed-off-by: Evan Jones [email protected]