-
Notifications
You must be signed in to change notification settings - Fork 332
[VSC-1739 | 1742 | 1735]Current setup download enhancements #1625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Download the artifacts for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, LGTM!
Thanks @brianignacio5 - nice work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fixes #1623
Fixes #1618
Fixes #1612
This pull request introduces improvements to the ESP-IDF tooling, focusing on enhancing download reliability, caching, and code maintainability. Key changes include replacing
downloadFile
anddownloadWithRetries
with a more robustdownloadWithResume
method, introducing caching for ESP-IDF version lists, and replacing themove
function with a customrobustMove
function for better error handling. Additionally, some dependencies and unused code have been removed for simplification.Improvements to download reliability:
downloadFile
anddownloadWithRetries
withdownloadWithResume
insrc/espIdf/documentation/getDocsVersion.ts
,src/setup/embedGitPy.ts
, andsrc/setup/espIdfDownload.ts
to support resumable downloads. [1] [2] [3] [4]Caching for ESP-IDF version lists:
src/setup/espIdfVersionList.ts
to store and retrieve ESP-IDF version lists, reducing redundant network requests. Includes cache validation, saving, and fallback mechanisms. [1] [2]Code maintainability and simplification:
move
withutils.robustMove
insrc/installManager.ts
,src/setup/espIdfDownload.ts
, andsrc/utils.ts
to improve error handling during file operations. [1] [2] [3] [4] [5]follow-redirects
,https-proxy-agent
) and related code, simplifyingpackage.json
andsrc/utils.ts
. [1] [2] [3]Updates to test cases:
src/test/suite/downloadManager.test.ts
to usedownloadWithResume
instead ofdownloadFile
. [1] [2]Miscellaneous:
idf_versions.txt
to include new ESP-IDF versions and remove outdated ones.Type of change
Please delete options that are not relevant.
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
More reliable idf_versions.txt, ESP-IDF and ESP-IDF tools download mechanism.
Fallback for idf_versions.txt used if unavailable first link, if download links break the user can continue the download from the previous attempt.
How has this been tested?
Manual steps as described above.
Test Configuration:
Checklist