feat(linenoise): Add linenoise library (IEC-328)

[SoucheSouche]

Checklist

• Component contains License
• Component contains README.md
• Component contains idf_component.yml file with url field defined
• Component was added to upload job
• Optional: Component contains unit tests
• CI passing

Change description

Add linenoise to the list of extra components. The library is used in the console component of esp-idf that is going through refactoring. One part of the refactoring is to move third party libraries outside of the console component. Eventually, the console component itself will be removed from esp-idf, reason why this PR adds the linenoise lib to the idf-extra-components.

[github-advanced-security]

clang-tidy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

[suda-morris]

There was a PR about the linenoise library: espressif/esp-idf#10526
WDYT? @SoucheSouche

[SoucheSouche]

There was a PR about the linenoise library: espressif/esp-idf#10526 WDYT? @SoucheSouche

@suda-morris
Yes, I am aware of it. I took into account Ivan's comment left in the PR when implementing this version of linenoise. The author of the PR you mentioned is aware that I will take over and continue the work on improving the console component (linenoise and more generally the list of idea he listed here espressif/esp-idf#9986)

[igrr]

Suggested change

	linenoise_handle_t linenoise_create_instance(linenoise_instance_param_t *param);
	esp_err_t linenoise_create_instance(const linenoise_instance_param_t *param, linenoise_handle_t* out_handle);

1. Configuration structure can be a const pointer
2. You may need to return different types of errors (out of RAM, invalid argument in the config structure, etc), which simply returning NULL doesn't allow. Hence, return esp_err_t and get the instance handle as an output argument.

[igrr]

What should the caller do if the "delete instance" function has returned an error?

[SoucheSouche]

the only way the function returns an error is if the handle is invalid. I understand the question but then I would also expect that it is also valid for the comment above. So either I update the linenoise_create_instance to return error values and I leave this function as it is now or I update linenoise_delete_instance to abort when the handle is invalid and I keep the function linenoise_create_insance as it is now.

Because I am not sure what the caller can do if linenoise_create_instance returns e.g., no memory error.

[igrr]

Is there a use case for changing these settings (empty_line, multi_line, dumb_mode, max_cmd_line_length) once the instance is already created? If there is no concrete use case, it might be simpler to not implement these getters and setters.

[SoucheSouche]

The user might want to repurpose an existing linenoise instance, instead of deleting the instance and creating a new one. In that case it might be useful to keep the getters and setters

[SoucheSouche]

@igrr, I updated the component based on your input. I left a few comments open for discussion.

I added a bunch of tests for the basic functionality of linenoise when escape sequences are supported by the terminal.

[SoucheSouche]

@igrr, I incorporated your second round of review (see 6e3c7a0). Please also check the comments I left below your comments from the first round of review.