Skip to content

Add missing break statements to usb_serial_jtag_ll_phy_select (IDFGH-14760) #15499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

renzenicolai
Copy link
Contributor

This commits adds two missing "break" statements to the usb_serial_jtag_ll_phy_select HAL function. The missing statements prevent users from switching back the two PHYs to the default configuration as the statement will always fall through to the second case in the switch case.

@CLAassistant
Copy link

CLAassistant commented Mar 1, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Mar 1, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello renzenicolai, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against c473492

@renzenicolai renzenicolai force-pushed the renze/bugfix-phy-select branch from dd4b03f to c473492 Compare March 1, 2025 09:09
@github-actions github-actions bot changed the title Add missing break statements to usb_serial_jtag_ll_phy_select Add missing break statements to usb_serial_jtag_ll_phy_select (IDFGH-14760) Mar 1, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Mar 1, 2025
@suda-morris
Copy link
Collaborator

sha=c47349272527ffd3e967f5ac2c228bda4812c86d

@suda-morris suda-morris added the PR-Sync-Merge Pull request sync as merge commit label Mar 3, 2025
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Mar 3, 2025
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: In Progress Work is in progress labels Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants