Skip to content

url encode decode package #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

url encode decode package #164

wants to merge 6 commits into from

Conversation

wdpk
Copy link

@wdpk wdpk commented Mar 24, 2025

package to url en(de)code clipboard contents using python

package to url en(de)code clipboard contents using python
Copy link
Collaborator

@smeech smeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two triggers to URL-encode and -decode clipboard contents, using Python scripts.
We're particularly cautious with scripts, and although these appear benign, they introduce some possible security risks, and might benefit from a line to check only URL-safe characters are present, to prevent injection risks.
The file-paths all need amending to include the version number, and I have queries about the lower-case Espanso environment variables, as these are usually uppercase.

@wdpk wdpk requested a review from smeech March 25, 2025 09:20
@wdpk
Copy link
Author

wdpk commented Mar 25, 2025

for checking that only url-safe characters are present, should i maybe cause a break if any of the "unsafe" characters as listed here are present? https://stackoverflow.com/a/695467 the answers list a regex i could use

@smeech
Copy link
Collaborator

smeech commented Mar 25, 2025

for checking that only url-safe characters are present, should i maybe cause a break if any of the "unsafe" characters as listed here are present? https://stackoverflow.com/a/695467 the answers list a regex i could use

Yes, I think it would be preferable to cause a break and/or perhaps return an error message string, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants