Skip to content

feat(translator): vrf support in backend #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 12, 2025

Conversation

crankynetman
Copy link
Collaborator

@crankynetman crankynetman commented Jan 28, 2025

This is a bit of large MR, sorry. This MR does a few things, all of it under the guise of supporting VRFs with GoBGP:

  1. Allows you to perform all of the translator actions inside of a VRF or on the base routing instance.
  2. Split out websocket message parsing a bit and added a lot more validation. This also means that the process() function is a lot more straight-forward and that logic was broken apart.
  3. We now use redis 🎉 ! This is because GoBGP can't give you just a single prefix's announcement status so we had to write that ourselves.
  4. A ton of loggers added all over the place as well as docstrings.

closes #44, implements the translator part of #35

Copy link

github-actions bot commented Feb 3, 2025

File Coverage
All files 81%
config/consumers.py 71%
config/urls.py 69%
config/settings/base.py 70%
config/settings/local.py 72%
scram/route_manager/admin.py 85%
scram/route_manager/models.py 70%
scram/route_manager/views.py 78%
scram/route_manager/api/serializers.py 73%
scram/route_manager/api/views.py 83%
scram/templates/403.html 91%
scram/templates/404.html 91%
scram/templates/base.html 99%

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 5161626

@crankynetman crankynetman changed the title WIP: backend vrf support feat(translator): vrf support in backend Feb 4, 2025
@crankynetman crankynetman marked this pull request as ready for review February 4, 2025 21:29
@crankynetman crankynetman self-assigned this Feb 5, 2025
@crankynetman crankynetman added the enhancement New feature or request label Feb 5, 2025
@crankynetman crankynetman changed the base branch from develop to main February 19, 2025 17:06
Copy link
Collaborator

@samoehlert samoehlert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can live with the slight drop in coverage if you believe it's not a problem

@crankynetman crankynetman merged commit e056edf into main Mar 12, 2025
18 of 20 checks passed
@crankynetman crankynetman deleted the topic/chriscummings/enable-backend-vrf-support branch March 12, 2025 17:54
@github-project-automation github-project-automation bot moved this from In review to Done in SCRAM Kanban Mar 12, 2025
crankynetman added a commit that referenced this pull request Mar 19, 2025
crankynetman added a commit that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Do some event data validation in translator.py
2 participants