-
Notifications
You must be signed in to change notification settings - Fork 4
feat(translator): vrf support in backend #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
crankynetman
merged 18 commits into
main
from
topic/chriscummings/enable-backend-vrf-support
Mar 12, 2025
Merged
feat(translator): vrf support in backend #129
crankynetman
merged 18 commits into
main
from
topic/chriscummings/enable-backend-vrf-support
Mar 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l points it needs to be filled.
Minimum allowed coverage is Generated by 🐒 cobertura-action against 5161626 |
…lt value into message processing.
…refixes are added to the cache properly.
samoehlert
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can live with the slight drop in coverage if you believe it's not a problem
crankynetman
added a commit
that referenced
this pull request
Mar 19, 2025
This reverts commit e056edf.
crankynetman
added a commit
that referenced
this pull request
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of large MR, sorry. This MR does a few things, all of it under the guise of supporting VRFs with GoBGP:
process()
function is a lot more straight-forward and that logic was broken apart.closes #44, implements the translator part of #35