Skip to content

feat: add checkFootnoteDefinitions option to no-empty-definitions #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 29, 2025

Conversation

TKDev7
Copy link
Contributor

@TKDev7 TKDev7 commented Jun 25, 2025

Prerequisites checklist

What is the purpose of this pull request?

This pull request extends the no-empty-definitions rule to also report empty footnote definitions in Markdown files. This helps ensure that both regular definitions and footnote definitions are meaningful and not left empty by mistake.

What changes did you make? (Give an overview)

  • Report empty footnote definitions (e.g., [^note]:) as problems by default.
  • Add a checkFootnoteDefinitions option (default: true) to control whether empty footnote definitions are reported.
  • Updated the rule documentation
  • Added tests

Related Issues

Fixes #435

Is there anything you'd like reviewers to focus on?

snitin315
snitin315 previously approved these changes Jun 27, 2025
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Leaving it open for @lumirlumir

Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@lumirlumir lumirlumir merged commit 4d504e5 into eslint:main Jun 29, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 29, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Complete in Triage Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Rule Change: Extend no-empty-definitions to cover empty footnote definitions
3 participants