-
-
Notifications
You must be signed in to change notification settings - Fork 22
Add Style Guide Canonical #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think in general we'll be removing all style guides as ESLint is getting out of the formatting business. @eslint/eslint-team thoughts? |
All style guides contain both formatting and non-formatting rules, I'm only not sure if we want to keep maintaining a list of external configs. |
As a user, I find it very convenient to be able to simply select a style guide at this point. That's why I would find it a loss if this was no longer possible. |
@mdjermanovic thoughts on this? |
I think it's generally fine that we keep style guides because style is not just formatting (there are many non-formatting stylistic rules in the core and plugins). We might just want to revisit the wording and flow of prompts, but that seems like a separate issue. As for this particular request:
|
Oops! It looks like we lost track of this issue. What do we want to do here? This issue will auto-close in 7 days without an update. |
So maybe instead of Canonical ESLint Stylistic? |
ESLint Stylistic isn't a style guide, it's a plugin, so it doesn't make sense to add here. |
I recommend including Canonical as a style guide and considering removing Google as it is no longer being developed. Here's a good comparison of the style guides: https://github.com/gajus/eslint-config-canonical/blob/main/COMPARISON_TABLE.md#table-of-comparison
The text was updated successfully, but these errors were encountered: