-
-
Notifications
You must be signed in to change notification settings - Fork 94
[Rule proposal] Limit usage of promise API to current ECMA standard #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't think I agree with this, because then the rule becomes less helpful to many people. Is there a specific case where it's handling bluebird (or other style) promises incorrectly? |
The problem is not incorrect handling but rather more than the standard. |
@tamirmen, @lidortal I think I misunderstood the proposal. Your suggestion here is a rule that might look like this:
Which would effectively ban you from doing any of the non-spec stuff like I think I'm okay with this idea, could you put together a proposal of what exactly should result in an error? |
Yes, this is the idea. IMO when someone uses non-spec stuff, an error should be returned with the message - follow the standard. |
This comment was marked as off-topic.
This comment was marked as off-topic.
#72 is related to this issue and has some useful test cases and implementation suggestions that would help in resolving this feature request. Help is wanted with a PR, but I will try to open a PR in the next week or so. Please communicate if you would like to contribute this feature! |
Today there are many libraries that enhance the ECMA standard, like bluebird.
It will be very helpful if we can enforce only usage of the standard and not super-set.
The text was updated successfully, but these errors were encountered: