Skip to content

feat: add config "flat/all" #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 2, 2025
Merged

feat: add config "flat/all" #401

merged 7 commits into from
Jul 2, 2025

Conversation

aladdin-add
Copy link

@aladdin-add aladdin-add commented Dec 23, 2024

open questions:

  1. need to add an equivalent eslintrc config?
    2. need to add language options?

fixes #400

@aladdin-add aladdin-add force-pushed the feat/all-config branch 3 times, most recently from 6acee02 to 1d59eae Compare December 23, 2024 09:49
@aladdin-add aladdin-add force-pushed the feat/all-config branch 3 times, most recently from 164bb72 to cb4be05 Compare December 24, 2024 03:01
@aladdin-add aladdin-add marked this pull request as ready for review December 24, 2024 03:12
@aladdin-add aladdin-add requested a review from a team December 24, 2024 03:13
Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a good idea #400 (comment)

@voxpelli
Copy link
Member

voxpelli commented Jan 8, 2025

If we document this the same way as ESLint did in eslint/eslint#19318 then I'm okay with this 👍

@scagood

This comment was marked as resolved.

@aladdin-add aladdin-add marked this pull request as draft January 22, 2025 12:11
@MichaelDeBoey
Copy link
Member

If we have clear documentation, I'm fine with merging this as well

@aladdin-add aladdin-add force-pushed the feat/all-config branch 2 times, most recently from 4fbfb26 to 190d265 Compare June 10, 2025 16:00
@aladdin-add aladdin-add marked this pull request as ready for review June 10, 2025 16:01
@aladdin-add aladdin-add requested review from voxpelli and scagood June 10, 2025 16:13
Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally 👍 to this documentation is clear and the recommended rules detection is super nice.

@aladdin-add aladdin-add requested a review from scagood July 1, 2025 16:09
@aladdin-add aladdin-add merged commit b6a0d71 into master Jul 2, 2025
32 checks passed
@aladdin-add aladdin-add deleted the feat/all-config branch July 2, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Request: Consider exporting config with all rules enabled
5 participants