Skip to content

475 undo poetry version pin #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2023
Merged

475 undo poetry version pin #482

merged 4 commits into from
Apr 21, 2023

Conversation

dfsp-spirit
Copy link
Collaborator

@dfsp-spirit dfsp-spirit commented Apr 20, 2023

Changes Summary

  • undo poetry version pin, see Undo poetry version pinning #475
  • also fixes minor issue discovered during testing that the documentation did not build anymore because syncopy.nwanalysis was renamed to syncopy.connectivity, but the old name was still referenced in the docs.

Reviewer Checklist

  • Are testing routines present?
  • Do objects in the global package namespace perform proper parsing of their input?
  • Are all docstrings complete and accurate?
  • Is the CHANGELOG.md up to date?

@dfsp-spirit dfsp-spirit self-assigned this Apr 20, 2023
@dfsp-spirit dfsp-spirit linked an issue Apr 20, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15 ⚠️

Comparison is base (4dd57ab) 68.99% compared to head (fb42fc0) 68.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #482      +/-   ##
==========================================
- Coverage   68.99%   68.84%   -0.15%     
==========================================
  Files          84       84              
  Lines       10134    10134              
  Branches     2082     2082              
==========================================
- Hits         6992     6977      -15     
- Misses       2614     2624      +10     
- Partials      528      533       +5     

see 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dfsp-spirit dfsp-spirit added the dependencies Pull requests that update a dependency file label Apr 20, 2023
@dfsp-spirit dfsp-spirit added the Documentation Documentation has to be written for the issue/feature/bug label Apr 20, 2023
@dfsp-spirit dfsp-spirit marked this pull request as ready for review April 21, 2023 08:32
@dfsp-spirit dfsp-spirit requested a review from tensionhead April 21, 2023 08:34
Copy link
Contributor

@tensionhead tensionhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thx for the fix!

@tensionhead tensionhead merged commit d2c74b1 into dev Apr 21, 2023
@tensionhead tensionhead deleted the 475_uno_poetry_version_pin branch April 21, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Documentation Documentation has to be written for the issue/feature/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undo poetry version pinning
2 participants