Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop -> release for 0.4.1 #211

Merged
merged 36 commits into from
Nov 25, 2024
Merged

develop -> release for 0.4.1 #211

merged 36 commits into from
Nov 25, 2024

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Nov 25, 2024

Description

Summary of changes

This pull request includes several changes across various files to update dependencies, improve compatibility, and enhance functionality. The most important changes include updating Python versions for CI, modifying dependencies, and adding new utility functions for tensor operations.

Dependency and Environment Updates:

Documentation Updates:

  • README.md and docs/source/install.rst: Updated JAX installation instructions to version 0.4.17. [1] [2]
  • docs/source/tutorial.rst: Added integration_domain parameter to the calculate_result method.

Code Enhancements:

Minor Code Cleanups:

  • Removed unnecessary imports and improved code readability in various files (torchquad/integration/boole.py, torchquad/integration/simpson.py, torchquad/integration/utils.py). [1] [2] [3]

Release notes

  • Bug fixes related to new jax versions
  • Bug fixes related to new TF versions
  • CI/CD maintenance

gomezzz and others added 30 commits June 15, 2023 10:21
release -> main (for v0.4.0)
release -> develop (for v0.4.0)
Try allowing to skip coverage comment
The test execution shows warnings about traces being potentially incorrect because the Python3 control flow is not completely recorded.
This includes conditions on the shape of the integration domain tensor.
Since the only arguments of the compiled integration function are the integrand and integration domain,
and the dimensionality of this integration domain is constant,
we can ignore the warnings.

After this change,
the two `get_jit_compiled_integrate` functions hide PyTorch trace compilation warnings with `warnings.filterwarnings`.
fixed a bug.
I fixed a bug for tutorial.rst.
The previous check if code is currently being compiled no longer works with new TensorFlow versions because the `Tensor` type is now called `SymbolicTensor`.

This change adds a helper function to check if code is being compiled for JAX, TensorFlow or PyTorch.
If tf.is_symbolic_tensor() is available, i.e. if the TensorFlow version is high enough,
we use this function to check if code is being compiled.

To avoid inconsistencies between backends,
the check for integration domain values is disabled if code is being compiled with PyTorch even if the check works with PyTorch.
Fix JIT compilation with TensorFlow >= 2.14.0
Fixing mamba setup in CI
main -> develop (Release 0.4.1)
- update docs
- mildly increased MC error bounds to allow for variance in jax
- Made domain setup consistent
- Further CI fixes
Copy link

@gomezzz gomezzz merged commit 5729761 into Release Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants