(fix): use static_argnums for jax jit
#165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ilan-gold Should we maybe wait with merging this until the JIT tests? 🤔 |
|
@gomezzz I'm find with that, yeah. |
|
Ok going to merge this first and then the next one so that we have the history. Out of curiosity and before I merge, why no squashing of merge commits? |
👍
Bold to assume there is a reason :D |
😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because of the
expand_func_values_and_squeeze_integraldecorator oncalculate_result, thejaxJIT has no way of knowing what isn_per_dimordimso we switch to numbered static arguments.Summary of changes
Resolved Issues
How Has This Been Tested?
Related Pull Requests