-
Notifications
You must be signed in to change notification settings - Fork 92
Make the ProgressDialog more readable #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I can confirm, there seem to be an error in implementation. Please fix it. |
fixed |
(I cannot confirm, still same. Problem is not related to closing, issue seems related to "Stopped".) |
Ok, can't reproduce this, at least I don't know how. However, I need to have a closer look on how it is meant to work and will try to find a better way to close the dialog properly. |
Hi @gismo2004 Ps.: |
} | ||
base.OnClosing(e); | ||
|
||
//find out, if the close button was pressed or if the window was closed by win.close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is bad practise write anything in window file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not! It depends on what has to be done!
@gismo2004 what this code do? Why is it needed?
|
Remove the code, run the program, close the dialog by clicking the win32 close button (right corner X) --> then you know... |
😂... Check your cpu load... 2023-03-16_18-24-46.mp4 |
@gismo2004 I got you. |
Update progress bar and dialog