compiler: Remove dead code from private-append optimization #6875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 296 suites 12m 47s ⏱️ Results for commit 1694e70. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
bjorng
approved these changes
Feb 16, 2023
bjorng
added
team:VM
bjorng
removed
the
testing
|
I have merged your other three pull requests. You can rebase now. |
With the decision to not introduce a private append variant of `bs_create_bin` which gracefully tolerates non-binary string arguments, we can remove many code paths in `beam_ssa_private_append.erl` which are never reached as we will never try to track and patch the tail field of a cons.
frej
force-pushed
the
frej/private-append-cleanup
branch
from
faf517a to
1694e70
Compare
|
Rebased. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the decision to not introduce a private append variant of
bs_create_binwhich gracefully tolerates non-binary string arguments, we can remove many code paths inbeam_ssa_private_append.erlwhich are never reached as we will never try to track and patch the tail field of a cons.