Skip to content

fix unit tests to not write in cwd #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2024
Merged

fix unit tests to not write in cwd #2134

merged 4 commits into from
Jun 24, 2024

Conversation

battlmonstr
Copy link
Contributor

Make sure that tests do not use a current working directory. They should use TemporaryDirectory for isolation.

@battlmonstr battlmonstr added the maintenance Some maintenance work (fix, refactor, rename, test...) label Jun 21, 2024
@battlmonstr battlmonstr requested a review from canepat June 21, 2024 15:04
@battlmonstr battlmonstr marked this pull request as ready for review June 21, 2024 15:17
@canepat canepat merged commit a066061 into master Jun 24, 2024
5 checks passed
@canepat canepat deleted the pr/testcwd branch June 24, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants