rpcdaemon: add stub for remote Execution engine #2060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canepat
added
the
maintenance
lupin012
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a stubbed remote implementation for
engine::ExecutionEngineinrpcmodule, covering at least partially the (unusual) case of querying the Engine API endpoint inrpcdaemonrun as standalone component.A proper implementation will rely on a remote client of our internal Execution gRPC API, which is already available (
execution::grpc::client::RemoteClient) but would require to refactor theexecutionmodule out of thenodemodule in order not to add an undesired dependency betweenrpcandnode.