Skip to content

state, consensus: skip requests check when receipts unavailable after exec #14107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2025
Merged

state, consensus: skip requests check when receipts unavailable after exec #14107

merged 3 commits into from
Mar 7, 2025

Conversation

somnathb1
Copy link
Contributor

No description provided.

@somnathb1 somnathb1 mentioned this pull request Mar 7, 2025
Closed
somnathb1
somnathb1 commented Mar 7, 2025
View reviewed changes
cmd/state/exec3/historical_trace_worker.go
@@ -180,7 +180,7 @@ func (rw *HistoricalTraceWorker) RunTxTask(txTask *state.TxTask) {
return core.SysCallContract(contract, data, rw.execArgs.ChainConfig, ibs, header, rw.execArgs.Engine, false /* constCall */)
}

_, _, _, err := rw.execArgs.Engine.Finalize(rw.execArgs.ChainConfig, types.CopyHeader(header), ibs, txTask.Txs, txTask.Uncles, txTask.BlockReceipts, txTask.Withdrawals, rw.chain, syscall, rw.logger)
_, _, _, err := rw.execArgs.Engine.Finalize(rw.execArgs.ChainConfig, types.CopyHeader(header), ibs, txTask.Txs, txTask.Uncles, txTask.BlockReceipts, txTask.Withdrawals, rw.chain, syscall, true /* skipReceiptsEval */, rw.logger)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here i don't know if receipts are available, but perhaps not needed to check it (?)

@somnathb1
Copy link
Contributor Author

I was able to sync sepolia from scratch (after first reproducing the issue)

@yperbasis yperbasis added this to the 3.0.0-rc3 milestone Mar 7, 2025
@somnathb1
Copy link
Contributor Author

Kurtosis good - https://github.com/erigontech/erigon/actions/runs/13719076004

yperbasis
yperbasis reviewed Mar 7, 2025
View reviewed changes
Copy link
Member

@yperbasis yperbasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipRequestsEval is probably a more accurate name than skipReceiptsEval

@somnathb1
Copy link
Contributor Author

skipRequestsEval is probably a more accurate name than skipReceiptsEval

skipRequestsEval - is what we are doing because we don't have receipts. skipReceiptsEval - is very clear on that. We may potentially change this in future.

@yperbasis
Copy link
Member

skipRequestsEval is probably a more accurate name than skipReceiptsEval

skipRequestsEval - is what we are doing because we don't have receipts. skipReceiptsEval - is very clear on that. We may potentially change this in future.

Well, when this flag is true, what we are doing essentially is not dequeueing/returning requests. But OK.

@somnathb1 somnathb1 merged commit 760e725 into main Mar 7, 2025
13 of 14 checks passed
@somnathb1 somnathb1 deleted the som/partial_block_skip branch March 7, 2025 12:09
somnathb1 added a commit that referenced this pull request Mar 7, 2025
@somnathb1
state, consensus: skip requests check when receipts unavailable after…
dbb358c 
… exec (#14107)
@somnathb1 somnathb1 mentioned this pull request Mar 7, 2025
Merged
somnathb1 added a commit that referenced this pull request Mar 7, 2025
@somnathb1
state, consensus: skip requests check when receipts unavailable after…
844c6cf 
… exec (#14107) (#14113)

Cherry pick #14107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yperbasis yperbasis yperbasis approved these changes

@Giulio2002 Giulio2002 Awaiting requested review from Giulio2002

@AskAlexSharov AskAlexSharov Awaiting requested review from AskAlexSharov

@JkLondon JkLondon Awaiting requested review from JkLondon

@taratorio taratorio Awaiting requested review from taratorio

Assignees
No one assigned
Labels
Pectra
Projects
None yet
Milestone
3.0.0-rc3
Development

Successfully merging this pull request may close these issues.
2 participants
@somnathb1 @yperbasis