Skip to content

[flaky] erigon/core/state tests on Mac due to github.com/shirou/gopsutil/[email protected]/cpu #14415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
taratorio opened this issue Apr 3, 2025 · 4 comments
Closed

[flaky] erigon/core/state tests on Mac due to github.com/shirou/gopsutil/[email protected]/cpu #14415

taratorio opened this issue Apr 3, 2025 · 4 comments
Assignees
@dvovk
Milestone
3.1.0

Comments

@taratorio
Copy link
Member

example: https://github.com/erigontech/erigon/actions/runs/14242430869/job/39915246141

panic: runtime error: unsafe.Slice: ptr is nil and len is not zero

goroutine 1 [running]:
github.com/shirou/gopsutil/v4/cpu.perCPUTimes(0x14000a37660)
	github.com/shirou/gopsutil/[email protected]/cpu/cpu_darwin.go:158 +0x4ec
github.com/shirou/gopsutil/v4/cpu.TimesWithContext({0x104548ae0?, 0x1400002d110?}, 0x1)
	github.com/shirou/gopsutil/[email protected]/cpu/cpu_darwin.go:70 +0x70
github.com/shirou/gopsutil/v4/cpu.Times(...)
	github.com/shirou/gopsutil/[email protected]/cpu/cpu_darwin.go:59
github.com/shirou/gopsutil/v4/cpu.init.0()
	github.com/shirou/gopsutil/[email protected]/cpu/cpu.go:65 +0xec
FAIL	github.com/erigontech/erigon/core/state	0.223s
@taratorio taratorio changed the title flakey erigon/core/state tests on Mac due to github.com/shirou/gopsutil/[email protected]/cpu [flakey] erigon/core/state tests on Mac due to github.com/shirou/gopsutil/[email protected]/cpu Apr 3, 2025
@VBulikov
Copy link
Member

VBulikov commented Apr 4, 2025

yperbasis added Imp1 as Importance

@VBulikov VBulikov added this to the 3.1.0 milestone Apr 4, 2025
@dvovk dvovk mentioned this issue Apr 7, 2025
Merged
@dvovk
Copy link
Collaborator

dvovk commented Apr 7, 2025

Should be resolved in #14477

@dvovk
Copy link
Collaborator

dvovk commented Apr 7, 2025

Introduced PR to gopsutils which should solve the issue shirou/gopsutil#1835

AskAlexSharov pushed a commit that referenced this issue Apr 8, 2025
@dvovk
Downgrade gopsutils version (#14477)
7742410 
Downgrade of the gopsutils dependency due to a regression introduced in
version v4.24.9.

After upgrading to gopsutils v4.24.9, we encountered issues detailed in
[Erigon Issue
#14415](#14415). The problem
appears to be introduced specifically in that release.

To maintain stability and avoid the regression, we are reverting
gopsutils to the last known working version until a fix is introduced
upstream.
@dvovk
Copy link
Collaborator

dvovk commented Apr 8, 2025

Should be fixed with #14477

@dvovk dvovk closed this as completed Apr 8, 2025
@taratorio taratorio changed the title [flakey] erigon/core/state tests on Mac due to github.com/shirou/gopsutil/[email protected]/cpu [flaky] erigon/core/state tests on Mac due to github.com/shirou/gopsutil/[email protected]/cpu Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvovk dvovk

Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
3 participants
@VBulikov @dvovk @taratorio