No "lambda_" in the definition of norm_tv()

[jacquesdurden]

Dear developers, it seems that the parameter lambda_ has been forgotten from the definition of norm_tv (as visible from here). Is it programmed like this on purpose?

[nperraud]

Hi @jacquesdurden ,
I think this parameter is inherited from the class norm.
See:

pyunlocbox/pyunlocbox/functions.py

Line 405 in 6618121

def __init__(self, lambda_=1, w=1, **kwargs):

[jacquesdurden]

Yes you right but inheritance is not enough here. In particular, if you set it, conversely to other norms, it has no effect, see the screenshot below. (not showed below, but the effect is the same on the proximal operator)

[nperraud]

Well I call this a bug. Thanks for spotting and reporting it.

[jacquesdurden]

I guess this amounts to simply inserting a "gamma=self.step*lambda_" at the right places in norm_tv's code

[nperraud]

yes, we have to replace T by gamma where gamma = self.lambda_ * T.
this also require to write some tests to be sure that everything is correct. I am not sure when I will have the time to do.
this.
If you want, you are welcome to submit a PR. :-)