Skip to content

[Issue #390]added the client._generate._get_known_symbols #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 7, 2022
Merged

[Issue #390]added the client._generate._get_known_symbols #391

merged 10 commits into from
Dec 7, 2022

Conversation

muddi900
Copy link
Contributor

@muddi900 muddi900 commented Dec 3, 2022 •
edited
Loading

Fixes: Issue #390, uses pre-PEP585 typing annotations.

edit: gitignores for local ide settings and test outputs

@junkmd junkmd linked an issue Dec 4, 2022 that may be closed by this pull request
fix type annotations in client._generate._get_known_symbols #390
Closed
junkmd
junkmd requested changes Dec 4, 2022
View reviewed changes
comtypes/client/_generate.py
@@ -17,7 +17,7 @@
from comtypes.tools import codegenerator, tlbparser

if TYPE_CHECKING:
from typing import Any, Tuple, List, Optional, Union as _UnionT
from typing import Any, Tuple, List, Optional, Dict, Union as _UnionT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

junkmd
junkmd requested changes Dec 5, 2022
View reviewed changes
junkmd
junkmd requested changes Dec 5, 2022
View reviewed changes
@junkmd
Copy link
Collaborator

junkmd commented Dec 5, 2022

Calm down please!
Many non #390 related files are included.

And revert .vscode line in .gitignore.

junkmd
junkmd requested changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@junkmd junkmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your environment only setting are should not add to the PR.

junkmd
junkmd requested changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@junkmd junkmd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please do such as git rm "custom location" -r.

"Your environment only setting are should not add to the PR." is no means to say that "You can add your non-ignored test outputs to the PR freely".

@junkmd
Copy link
Collaborator

junkmd commented Dec 5, 2022

@muddi900

If you are not sure what the commands mean or what the final destination should be, please feel free to ask questions.

@muddi900
Copy link
Contributor Author

muddi900 commented Dec 6, 2022

@muddi900

If you are not sure what the commands mean or what the final destination should be, please feel free to ask questions.

Is there a contribution doc? I couldn't find it in the docs.

@junkmd
Copy link
Collaborator

junkmd commented Dec 6, 2022

@muddi900

a contribution doc?

I'm working on that, please see #387.

I have recently been attempting to increase contributors in this community.

Therefore, there are still imperfections. Sorry.

@muddi900
Copy link
Contributor Author

muddi900 commented Dec 6, 2022 via email

junkmd
junkmd requested changes Dec 6, 2022
View reviewed changes
@junkmd
Copy link
Collaborator

junkmd commented Dec 6, 2022

@muddi900

As a recommendation, you should deactivate the auto-formatter in VSCode's workspace settings.

Applying your formatter to a project that does not use a formatter or uses a different type of formatter and settings, such as this project, can cause unexpected changes.

junkmd
junkmd requested changes Dec 7, 2022
View reviewed changes
.vscode/settings.json Outdated
@@ -0,0 +1,3 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not needed.

You should need to stage or commit files individually, without doing things like git add . which could involve unrelated files.

junkmd added a commit to junkmd/pywinauto that referenced this pull request Dec 7, 2022
@junkmd
test enthought/comtypes#391
d834cc8
junkmd
junkmd approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@junkmd junkmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type annotations are fixed. Thanks @muddi900

misc

https://ci.appveyor.com/project/pywinauto/pywinauto/builds/45610244

@junkmd junkmd merged commit 4dd5b1e into enthought:master Dec 7, 2022
CristiFati pushed a commit to CristiFati/comtypes that referenced this pull request Dec 13, 2022
@muddi900 @CristiFati
[Issue enthought#390]added the client._generate._get_known_symbols (e…
f055eb2 
…nthought#391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junkmd junkmd junkmd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix type annotations in client._generate._get_known_symbols
2 participants
@muddi900 @junkmd