add type annotations to client/__init__.py
#389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Nov 29, 2022
|
I requested your review because I think it would be healthier for the community to have you review the PRs I submit. This PR is the last of adding type annotations to the statically defined modules mentioned in #327. As next step, or at the same time, change of the |
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Nov 30, 2022
vasily-v-ryabov
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #327
There are functions in this module those in some cases return
lazybind.Dispatch.However,
lazybindmodule does not yet have type annotations.lazybind.Dispatchis an object that implements__getattr__and__setattr__, the type checker will not error even if specifying a non-existing member.So for now, each function is annotated to return
Anyif theinterfaceis not explicitly specified in the argument.