...METHOD and ...PROPERTY return _MemberSpecs instead of tuples
#367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasily-v-ryabov
added a commit
to vasily-v-ryabov/pywinauto
that referenced
this pull request
Nov 3, 2022
vasily-v-ryabov
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STDMETHOD,COMMETHOD,DISPMETHOD, andDISPPROPERTYreturntuples of complex elements.This reduces the readability of the code flow and makes type annotation difficult.
They should return instances of the other classes, as commented(938fbd5) by Thomas Heller, the originator of this package.
comtypes/comtypes/__init__.py
Lines 1092 to 1093 in b331d3c
Elements of
_methods_and_disp_methods_specify members of that type.They should be 'private classes', instantiated only through these functions.
Therefore, they are named
_FooMemberSpec.They have
__iter__method, so that they can be used as unpackable objects liketuple.In future PRs, I plan to change the existing code to reference their attributes and without unpacking them.