remove CodeGenerator.need_GUID
#357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Sep 29, 2022
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Sep 30, 2022
vasily-v-ryabov
added a commit
to vasily-v-ryabov/pywinauto
that referenced
this pull request
Nov 1, 2022
vasily-v-ryabov
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GUIDsymbol is defined statically incomtypes/__init__.py, so it is always existing incomtypesmodule namespace.Therefore,
if "GUID" in self.known_symbols:inCodeGenerator.need_GUIDwas alwaysTrue. It was a redundant process.So I have removed the
need_GUIDmethod and instead useself.imports.add("comtypes", "GUID")which is more concise and does the same thing.This is a refactoring of the
codegeneratorbefore adding the stub generation process and is related to #327.