Skip to content

Add httpx-retries to third party packages docs #3552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

will-ockmore
Copy link
Contributor

@will-ockmore will-ockmore commented Apr 20, 2025

Summary

httpx-retries is a third-party package which implements request retry.

There's been extensive discussion on this feature in #108 - take a look at the end of the thread (specifically, the recent comment I left) for the current state of play.

I've added the package to the third-party packages docs; I've also sorted the entries alphabetically, as there's quite a few, to make it easier to browse (if this is an undesired change, let me know, I'll revert it!). I've run the docs locally, to verify everything looks good.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Sorts the entries on the page to make it easier to browse.
@tomchristie
Copy link
Member

tomchristie commented May 2, 2025

I didn't +/- this initially because I was blocked by the awkwardness of some of the entries on this page.
Pointed towards a couple of obvious places.

They're unrelated to your addition, so we can either be neat and tidy and deal with different aspects in different PRs or else we can be pragmatic and deal with them up as part of this pull request. (Or we can be non-plussed)

@will-ockmore
Copy link
Contributor Author

@tomchristie as I started the cleanup here by sorting the entries, I thought why not continue with the pragmatic approach.

I've included your comments, as well as some grammar improvements, and separated out libs that have HTTPX support from direct plugins.

An additional change we could make here if there's appetite is to remove duplication; there are two libraries for mocking, and two cache libraries.

@will-ockmore will-ockmore force-pushed the wo/add-httpx-retries-to-docs branch from 06c9c7e to 59cf696 Compare May 2, 2025 09:42
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lil' spruce up. Neato. 👍🏼
Not going to deal with de-dup just yet.

@tomchristie tomchristie merged commit 6c7af96 into encode:master May 2, 2025
6 checks passed
@will-ockmore will-ockmore deleted the wo/add-httpx-retries-to-docs branch May 2, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants