Skip to content

Drop HTML line breaks on long headers in browsable API #9438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 28, 2025

Conversation

tomchristie
Copy link
Member

Reverts #777

We don't really need to add line breaks <br> in the browsable API on long headers. They render fine in the browser as-is.
Superseeds fix in #9435 dealing with possible XSS against the browsable API.

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was some merge conflicts, so I tried to fix them

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be we need to remove related tests as well?

Copy link

stale bot commented Apr 27, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 27, 2025
@stale stale bot removed the stale label Apr 27, 2025
@browniebroke browniebroke changed the title Drop HTML line breaks on long headers. Drop HTML line breaks on long headers in browsable API Apr 27, 2025
@auvipy auvipy merged commit 78e9707 into master Apr 28, 2025
7 checks passed
@auvipy auvipy deleted the drop-break-long-headers branch April 28, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants