Modify AND and OR permission operands to have the ability to use custom messages
#6499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samitnuk
changed the title
AND operand to have the ability to use custom messages
samitnuk
changed the title
AND and OR permission operands to have the ability to use custom messages
|
Closed because of missed Ready for review button.
Expected https://help.github.com/en/articles/changing-the-stage-of-a-pull-request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #6427
AND- If failed permission has a message, it will be returned.OR- If both permissions will be failed:a) if both permissions have messages - will be returned one message combined from two messages;
b) if only one permission (from both failed) has a message - this message will be returned (I suppose this is better then return the default one).
NOT- untouched here since in any case, we cannot use the message from "inverted" permission.@carltongibson please comment. Thanks.