Various maintenance tasks #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix ActuatorLevel model issues - Fix comment typos
Previously if multiple entities where added in an update, addition was happening also multiple times for every entity. Also a removed entity was “added” as well. The code checked if the entity already existed and exited, so there was no issue with this. But it was unnecessary to do so. This change adds the option to only add a specific entity of a dataset to improve this.
Use DeviceRemote and EntityRemote of a message directly as they have to be available, instead of getting them via FeatureRemote.
Instead of using the `message.FeatureRemote` in the DeviceChange message, change the logic in device_local. When a remote device is adding, we need to send a subscription request to the NodeManagement feature. As the remote device, the entity address, feature type and role are all known, fetch the feature and its address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.