Skip to content

Add support for handling duplicate read messages #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

DerAndereAndi
Copy link
Member

@DerAndereAndi DerAndereAndi commented Aug 28, 2024

If different use case implementations trigger the same read messages, currently they are all sent through and result in multiple responses.

This change will cache up to the last 20 read messages for each feature and not resend duplicates to the same remote feature. Instead it will return the message counter of the previous read request, so all requestors will get the same responses.

Fixes #27

If different use case implementations trigger the same read messages, currently they are all sent through and result in multiple responses.

This change will cache up to the last 20 read messages for each feature and not resend duplicates to the same remote feature. Instead it will return the message counter of the previous read request, so all requestors will get the same responses.
@coveralls
Copy link

Coverage Status

coverage: 93.501% (+0.04%) from 93.465%
when pulling 8116edb on feature/read-duplicates
into 354299c on dev.

@DerAndereAndi DerAndereAndi added the enhancement New feature or request label Aug 28, 2024
@DerAndereAndi DerAndereAndi merged commit f6a290c into dev Aug 28, 2024
6 checks passed
@DerAndereAndi DerAndereAndi deleted the feature/read-duplicates branch August 28, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't send duplicate read messages if previous are not replied to yet
2 participants