Fix subscription removal for multiple remotes #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DerAndereAndi
commented
Aug 6, 2024
DerAndereAndi
commented
- When a service has multiple similar remote devices (EVSEs with attached EVs), then removing an EV did remove the subscriptions for all remote EVs and therefor these wallboxes switched into fallback mode. This change fixes this
- Add more tests for NodeManagementDetailedDiscovery entity removal
- When a service has multiple similar remote devices (EVSEs with attached EVs), then removing an EV did remove the subscriptions for all remote EVs and therefor these wallboxes switched into fallback mode. This change fixes this - Add more tests for NodeManagementDetailedDiscovery entity removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.