Skip to content

export tags #3320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kireerik opened this issue Mar 24, 2025 · 2 comments
Open

export tags #3320

kireerik opened this issue Mar 24, 2025 · 2 comments

Comments

@kireerik
Copy link

kireerik commented Mar 24, 2025

The problem

In version 11.13.5 and below I was able to directly import the tags module like this:
https://github.com/kireerik/refo/blob/0f64433e4dc99c8643ec68b0977f4a00c0998465/module/style/index.jsx#L6-L9

(Version 11.14.0 uses TypeScript. So I won't be able to do the above as is.)

Proposed solution

Make the tags module importable from @emotion/styled like this for example:

import tags from '@emotion/styled/tags'

Alternative solutions

import {tags} from '@emotion/styled'

 
2. Make the tags module a separate package like @emotion/tags for example.

@Andarist
Copy link
Member

import tags from '@emotion/styled/tags'

We could make this work. PRs are welcome.

kireerik added a commit to kireerik/emotion that referenced this issue Apr 3, 2025
@kireerik kireerik mentioned this issue Apr 3, 2025
4 tasks
kireerik added a commit to kireerik/emotion that referenced this issue Apr 3, 2025
kireerik added a commit to kireerik/emotion that referenced this issue Apr 3, 2025
kireerik added a commit to kireerik/emotion that referenced this issue Apr 3, 2025
kireerik added a commit to kireerik/emotion that referenced this issue Apr 3, 2025
@kireerik
Copy link
Author

kireerik commented Apr 3, 2025

Sounds good. I think something like this (main...kireerik:emotion:2ef91c8) should work, but only the CodeSandbox test passed like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants